Remote GSM #451
Closed
Remote GSM #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@miguelmtzinf all comments have been addressed, thanks for the name suggestions, didn't know what to use! |
| require(initialOwner != address(0), 'ZERO_ADDRESS_NOT_VALID'); | ||
| require(ghoAddress != address(0), 'ZERO_ADDRESS_NOT_VALID'); | ||
|
|
||
| _transferOwnership(initialOwner); |
Member
There was a problem hiding this comment.
this is an upgradeable contract, shouldn't mix setting immutable's and storage vars in constructor here, simply _disableInitializer for locking the impl and having null owner there is fine
Contributor
Author
|
@miguelmtzinf I've added enumerableSet. |
miguelmtzinf
reviewed
Jun 2, 2025
miguelmtzinf
reviewed
Jun 2, 2025
miguelmtzinf
reviewed
Jun 2, 2025
miguelmtzinf
reviewed
Jun 2, 2025
miguelmtzinf
reviewed
Jun 2, 2025
miguelmtzinf
reviewed
Jun 2, 2025
Contributor
|
Closing in favor of aave-dao/gho-origin#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Add RemoteGSM Implementation
Abstract methods on GSM